[PATCH] D29664: [LLD][ELF] Refactor PltSection and IPltSection common code into a base class NFC

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 13:05:16 PST 2017


ruiu added a comment.

It is probably my taste, but I'd try to keep the class hierarchy as shallow as possible. Looks like IPLT and PLT are pretty similar. I wonder if you can merge PltBase, Plt and Iplt into one class, add IsIplt boolean flag, and do whatever it is needed to do for IPLT according to the flag.


https://reviews.llvm.org/D29664





More information about the llvm-commits mailing list