[PATCH] D29169: Do not apply redundant LastCallToStaticBonus

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 10:12:02 PST 2017


eraman accepted this revision.
eraman added a comment.
This revision is now accepted and ready to land.

LGTM.

  I'm generally wary of fixes that cause regression without providing any benefits and it is preferable that the root cause of the regression is addressed before fixing the bug.  But in this case the conditions that trigger size regression are not going to be commonplace and fixing the root cause (huge size increases when multiple callsites get inlined into a single function) does not have an easy fix, so I'm fine with the patch. However, wait to see if Chandler has a different opinion in which case I'll defer to him.


https://reviews.llvm.org/D29169





More information about the llvm-commits mailing list