[PATCH] D29636: [ELF] - Added partial support for --emit-relocs (no --gc-section case) #2

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 08:42:42 PST 2017


It is not a question of importance, it is a question of easy of review.

I am under the impression that it would be way easier to first review a
version without gc or DISCARD and then review a change that makes both
gc and DISCARD work.

Cheers,
Rafael

George Rimar <grimar at accesssoftek.com> writes:

>>I still think we should leave the DISCARD and gc case for a followup
>>patch. Without it this is a trivial patch.
>>
>>Cheers,
>>Rafael
>
> GC case is not used in kernel, and I would postpone it's support until we have users.
> But /DISCARD/ is used and therefore important.
>
> I can prepare one more version without /DISCARD/ if that makes sence.
>
> George.


More information about the llvm-commits mailing list