[PATCH] D29105: Fix regalloc assignment of overlapping registers

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 20:12:22 PST 2017


rampitec added a comment.

In https://reviews.llvm.org/D29105#668628, @MatzeB wrote:

> This commit broke an internal target for us as it can choose subregister indexes which are not compatible with a given register class. Maybe we should go for the simpler `LI->clearSubRanges()` instead of the whole subreg aware copying for now even though that may pessimize the code.


It's been broken before, but now we have indication, right?
I have tried to use LI->clearSubRanges() either as an alone solution or as a backup if subreg search fails. It does not work, later on we hit assertion that a new subrange (because by clearing ranges we are creating new in fact) was not found in parent LI...


Repository:
  rL LLVM

https://reviews.llvm.org/D29105





More information about the llvm-commits mailing list