[PATCH] D28182: COFF: tie the execute and the PDB together

[Saleem Abdulrasool via llvm-commits]

On Mon, Feb 6, 2017 at 2:24 PM, Bob Haarman via Phabricator <
reviews at reviews.llvm.org> wrote:

> inglorion added inline comments.
>
>
> ================
> Comment at: COFF/Writer.cpp:307
> +    createPDB(Config->PDBPath, Symtab, SectionTable, BuildId->DI);
>
>    if (auto EC = Buffer->commit())
>      fatal(EC, "failed to write the output file");
> ----------------
> This is causing the linker to crash for me, because BuildId is nullptr.
> @compnerd, does that suggest a problem and a fix, or shall I do some more
> digging and cook up a patch?


Thats an oversight on my part.  That implies that no debug info was
generated, which means that BuildId will be a nullptr.  Ill try to fix this
soon; thanks for pointing it out!


>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28182
>
>
>
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170206/9e997d06/attachment.html>