[PATCH] D29590: Generalize SHF_LINK_ORDER to user defined sections

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 12:06:43 PST 2017


Reid Kleckner via Phabricator <reviews at reviews.llvm.org> writes:

> rnk added a comment.
>
> lgtm
>
>
>
> ================
> Comment at: lld/ELF/MarkLive.cpp:170
>    default:
> +    if (Sec->Flags & SHF_LINK_ORDER)
> +      return false;
> ----------------
> Do we already have the dependency from the associated section? It looks like LLD has some logic for it, but I can't tell if it's enough.

Yes, that is what is used by the arm unwind tables.

Cheers,
Rafael


More information about the llvm-commits mailing list