[PATCH] D29443: [DAGCombine] Combine composition of ADDC(ADDE)

Amjad Aboud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 07:26:03 PST 2017


aaboud added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1919
+  if (!N->hasAnyUseOfValue(1)) {
+    // (adde (add|addc X, Y), 0, Carry) -> (adde X, Y, Carry)
+    if ((N0.getOpcode() == ISD::ADD || N0.getOpcode() == ISD::ADDC) &&
----------------
Is it worth checking that Carry != A:Carry, where A = add X, Y (or A = addc X, Y) ?


https://reviews.llvm.org/D29443





More information about the llvm-commits mailing list