[PATCH] D29524: [DAGCombiner] Make DAGCombiner smarter about overflow

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

One last comment.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2780
+      (~N1Zero & 0x01) == ~N1Zero)
+    return OverflowKind::Never;
+
----------------
deadalnix wrote:
> RKSimon wrote:
> > Does the test cases cover both of these patterns? Its not clear if it does.
> I need some more improvement in the handling of adde/addc ( D29443 ) to expose the second one. then it kicks in in muladd in test/CodeGen/X86/adde-carry.ll
In which case please can you drop this case until you can test for it? You can include it in another patch for review and commit it separately if you wish.


https://reviews.llvm.org/D29524