[PATCH] D29564: [DAGCombiner] (add X, (adde Y, 0, Carry)) -> (adde X, Y, Carry)

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 21:13:05 PST 2017

zvi added inline comments.

Comment at: test/CodeGen/X86/adde-carry.ll:89
 define %scalar @pr31719(%scalar* nocapture readonly %this, %scalar %arg.b) {
 ; CHECK-LABEL: pr31719:
If you intend to improve this test case in future patches, i think you should add a dedicated minimal test to ensure the combine introduced this patch will be covered. Other than that LGTM 


More information about the llvm-commits mailing list