[PATCH] D29521: Add ADDC to SelectionDAG::computeKnownBits and ComputeNumSignBits.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 12:01:28 PST 2017

RKSimon added a comment.

In https://reviews.llvm.org/D29521#667282, @deadalnix wrote:

> In https://reviews.llvm.org/D29521#667258, @davide wrote:
> > Probably you can mimic the tests for add (if any?)
> I'm not aware of any, however, surely, there is some test somewhere that depends on it. I'll try removing the add case and see what breaks.

There are very few scalar tests - llvm\test\CodeGen\X86\known-bits.ll is almost empty. The llvm\test\CodeGen\X86\known-bits-vector.ll has more examples - scalarizing one of those should be trivial.


More information about the llvm-commits mailing list