[PATCH] D29268: [DAGCombine] Combine composition of ADDC(ADDE)

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 07:45:30 PST 2017

zvi added a comment.

In https://reviews.llvm.org/D29268#666957, @deadalnix wrote:

> Shall we close this one in favor of https://reviews.llvm.org/D29443 ?

I don't mind abandoning this patch in favor of https://reviews.llvm.org/D29443, but if possible, i think you should break https://reviews.llvm.org/D29443 into several patches. I'm saying this because https://reviews.llvm.org/D29443 adds several new combines and it would be easier to review each combine in a separate patch with tests that show its goodness.
So it may turn out that after breaking https://reviews.llvm.org/D29443, this patch will end-up as the initial patch in a sequence. Does this make sense?



More information about the llvm-commits mailing list