[PATCH] D29524: [DAGCombiner] Make DAGCombiner smarter about overflow

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 5 04:53:37 PST 2017


RKSimon added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAG.h:1283
+
+  OverflowKind computeOverflowKind(SDValue N0, SDValue N1) const;
+
----------------
Please document both the enum and the method.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1836
   EVT VT = N0.getValueType();
+  auto DL = SDLoc(N);
 
----------------
SDLoc DL(N);


https://reviews.llvm.org/D29524





More information about the llvm-commits mailing list