[PATCH] D29555: [CMake] Fix pthread handling for out-of-tree builds
Eric Fiselier via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 5 04:35:35 PST 2017
EricWF added inline comments.
Comment at: cmake/modules/LLVMConfig.cmake.in:49
+if (NOT "@LLVM_PTHREAD_LIB@" STREQUAL "")
+ set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
+ set(THREADS_HAVE_PTHREAD_ARG Off)
> Are you sure that this is safe to do for every package doing `find_package(LLVM)`?
Perhaps not. I tested without it and it didn't immediately seem needed, at least on my platform. I'll look into moving or removing it.
More information about the llvm-commits