[PATCH] D29069: [MSP430] Add SRet support to MSP430 target

Vadzim Dambrouski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 4 13:57:21 PST 2017

pftbest added a comment.

As I see it, CurrentArgIndex is overloaded with two (or more) tasks, so the code is confusing. Maybe it would be better if CurrentArgIndex was just a counter, and the other conditions can be handled by introducing boolean flags, for example.


More information about the llvm-commits mailing list