[PATCH] D28978: [ThinLTO] Add an auto-hide feature

[Mehdi Amini via llvm-commits]

Something is strange, looking at _ZSt4endlIcSt11char_traitsIcEERSt13basic_ostreamIT_T0_ES6_ it is available_externally in every *.0.preopt.bc. There are no real definition.
It may be that the hiding interfered with the weak resolution? I’m not sure why / where thought.

(As a side note, it seems that the 0.preopt.bc has already received some changed compared to the input. I wasn’t expecting this!)

 
— 
Mehdi

> On Feb 3, 2017, at 12:07 PM, Teresa Johnson <tejohnson at google.com> wrote:
> 
> 
> 
> On Fri, Feb 3, 2017 at 7:08 AM, Mehdi Amini <mehdi.amini at apple.com <mailto:mehdi.amini at apple.com>> wrote:
> I’d be interested to look at this.
> If it is not too big can you upload an archive of --save-temps?
> 
> Uploaded a zip here:  https://drive.google.com/open?id=0B036uwnWM6RWZDduZEJWaUJvdmM <https://drive.google.com/open?id=0B036uwnWM6RWZDduZEJWaUJvdmM>
> 
> Teresa
> 
> 
> Thanks,
> 
> —
> Mehdi
> 
> > On Feb 3, 2017, at 6:49 AM, Teresa Johnson via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> >
> > tejohnson added a comment.
> >
> > FYI I also just confirmed that this patch was causing linker errors in SPEC 450.soplex of the form:
> >
> > /usr/bin/ld: error: hidden symbol '_ZStlsISt11char_traitsIcEERSt13basic_ostreamIcT_ES5_PKc' is not defined locally
> > /usr/bin/ld: error: hidden symbol '_ZSt4endlIcSt11char_traitsIcEERSt13basic_ostreamIT_T0_ES6_' is not defined locally
> >
> >
> > Repository:
> >  rL LLVM
> >
> > https://reviews.llvm.org/D28978 <https://reviews.llvm.org/D28978>
> >
> >
> >
> 
> 
> 
> 
> -- 
> Teresa Johnson |	 Software Engineer |	 tejohnson at google.com <mailto:tejohnson at google.com> |	 408-460-2413

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170204/e03cc0a4/attachment.html>