[PATCH] D29240: IR: Consider two DISubprograms to be odr-equal if they have the same template parameters.

[Duncan P. N. Exon Smith via llvm-commits]

I spent some more time on this and I understand the failure.

I'm really uncomfortable with the fix, though.  It seems partial -- it fixes the particular crash you found, but couldn't this happen with other fields in DISubprogram?

Also, where does the ValueMapper run in this opt invocation?  Is that what -run-twice does?

> On 2017-Feb-03, at 14:44, Peter Collingbourne via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> pcc added a comment.
> 
> Ping. Since the long term fix probably won't happen any time soon, does anyone have any objection to this?
> 
> 
> https://reviews.llvm.org/D29240
> 
> 
>