[PATCH] D29512: [PGO] Directory name stripping in global identifier for static functions

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 13:59:06 PST 2017

xur added a comment.

thanks to Teresa for the collection. I'll update the patch shortly

Comment at: lib/IR/Globals.cpp:38
+    cl::desc("Strip specified level of directory name from source paths in "
+             "the profile counter names for static functions."));
tejohnson wrote:
> It isn't just profile counter names. "in the global identifier for static functions". 

Comment at: lib/ProfileData/InstrProf.cpp:31
 static cl::opt<bool> StaticFuncFullModulePrefix(
+    "static-func-full-module-prefix", cl::init(true),
tejohnson wrote:
> Should this one be removed, is it useful with the new option?
This will be removed later as we assume this options is being used by the users.


More information about the llvm-commits mailing list