[PATCH] D29485: [Builtin][ARM] Implement addsf3/__aeabi_fadd for Thumb1

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 12:25:51 PST 2017

efriedma added a comment.

> all constants are materialized instead of loading from constant pool
>  no stack spills (C version uses 136 bytes stack space)
>  clz() is called only when necessary. (C version always calls it)

If we have to hand-write assembly to efficiently materialize constants, something has gone very wrong.  It's better to fix the compiler if we can; please file bugs for these issues.


More information about the llvm-commits mailing list