[llvm] r292189 - [TLI] Robustize SDAG proto checking by merging it into TLI.

Ahmed Bougacha via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 11:24:23 PST 2017

Thanks!  Gave it another shot as r294028.


On Mon, Jan 30, 2017 at 5:29 AM, Ulrich Weigand
<Ulrich.Weigand at de.ibm.com> wrote:
> Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote on 28.01.2017 04:13:19:
>> I reverted this in r292191 because it broke some SystemZ tests I
>> missed locally (e.g., test/CodeGen/SystemZ/strlen-02.ll) that
>> explicitly check lowering for "incorrect" libc functions.  For
>> instance, a 'size_t' parameter being passed as an 'i32' on a 64-bit
>> target.
>> Do you rely on that behavior, or should I simply remove those tests?
>> I feel confident making that call on X86, but you might have different
>> requirements.
> Yes, I think those tests can be removed.
> Bye,
> Ulrich

More information about the llvm-commits mailing list