[PATCH] D29425: [SLP] Use SCEV to sort memory accesses

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 11:11:49 PST 2017


mkuper added a comment.

Thanks!



================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1096
+
+    OffValPairs.emplace_back(
+        std::make_pair(Diff->getAPInt().getSExtValue(), Val));
----------------
sanjoy wrote:
> Do you need the `std::make_pair`?  Can't you do `emplace_back(Diff->getAPInt().getSExtValue(), Val)`?
Ugh, right, thanks!


https://reviews.llvm.org/D29425





More information about the llvm-commits mailing list