[PATCH] D29490: [ELF] - Use SignExtend when reading R_386_PC8 addend.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 10:22:14 PST 2017


George Rimar <grimar at accesssoftek.com> writes:

>>%S/Inputs/i386-pc8.s is missing, but why do you need it to be in another
>>file?
>>
>>It is not missing, we already have one committed.
>>
>>George.
>
> And we already used it in i386-pc8.s test to produce
> PC8 relocations using undefined symbols:
>
> .byte und-.+0x11
> .byte und-.+0x22
>
> So doing here the same. Anything wrong with this approach ?

It is more complicated than it needs to be. You can define und on this
file, it just needs to be in another section.

Cheers,
Rafael


More information about the llvm-commits mailing list