[PATCH] D29341: [scudo] 32-bit quarantine sizes adjustments and bug fixes

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl requested changes to this revision.
alekseyshl added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/scudo/scudo_flags.cpp:71
   if (f->QuarantineSizeMb < 0) {
-    const int DefaultQuarantineSizeMb = 64;
+    const int DefaultQuarantineSizeMb = FIRST_32_SECOND_64(16, 64);
     f->QuarantineSizeMb = DefaultQuarantineSizeMb;
----------------
So, scudo default quarantine size is less than asan's one? Is there a reason?


================
Comment at: test/scudo/quarantine.cpp:61
+    if (found == false)
+      return 1;
   }
----------------
Wouldn't assert(CONDITION); be more debug friendly than if (!CONDITION) return 1; throughout? Should any of those tests break, to figure out what exactly went wrong, one will have to either step through the code or add printfs/asserts anyway.


https://reviews.llvm.org/D29341