[PATCH] D29404: [ValueTracking] emit a warning when we detect a conflicting assumption (PR31809)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 09:11:16 PST 2017
spatel updated this revision to Diff 86974.
spatel added a comment.
1. Given Eli's observation about the potential to hit this case validly, soften this back to a OptimizationRemarkAnalysis() and use wishy-washy words in the remark.
2. Add SimplifyInstructions dependency on OptimizationRemarkEmitter and stash the ORE pointer in the Query struct as suggested. I've tried to minimize the diffs by making the ORE an optional param, but this still seems to require a lot of code. If I understand correctly, we would have to do this for all passes that use value tracking and update all calls into value tracking to guarantee that a remark is printed.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12032 bytes
Desc: not available
More information about the llvm-commits