[PATCH] D29392: [ELF] - Change value checks to checkUInt for R_386_8/R_386_PC8/R_386_16/R_386_PC16 relocations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 07:45:37 PST 2017


>So, with the fix for reading the addend as a signed number for the pc
>relocation, can you use checkInt for PC and checkUint for non-pc in
>here?
>
>Cheers,
>Rafael

checkInts are already used for PC ones. And my new tests passes fine.
So yes, probably we can change non-pc to checkUint safely, since
that is more relaxed check in compare with checkInt.

George.


More information about the llvm-commits mailing list