[PATCH] D29425: [SLP] Use SCEV to sort memory accesses

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 06:48:17 PST 2017

mssimpso added inline comments.

Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1081
+    if (CurrObj != Obj0) {
+      Sorted.append(VL.begin(), VL.end());
+      return;
Hi Michael,

I must have missed this the first time around, but this looks a little confusing to me. If the accesses aren't sortable, why are we adding them to Sorted? I would think the caller would need some signal that sorting was unsuccessful - either an empty Sorted or a returned bool. Am I missing something obvious?


More information about the llvm-commits mailing list