[PATCH] D27933: [InstCombine] fix operand-complexity-based canonicalization (PR28296)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 3 06:43:28 PST 2017
spatel updated this revision to Diff 86953.
spatel added a comment.
1. Added code comment with examples to explain the general motivation for complexity-based canonicalization. I'm not sure what the trade-offs are vs. other schemes, so I didn't add more. Please let me know if you'd like to see something else here.
2. Limited 'rank 4' to cast ops and fake unary ops (neg/fneg/not). Cast ops are my motivation for this patch because I've seen problems with those patterns at least 3 times. For reference, the earlier rev included all unary ops, and these are the additional types in that bucket:
There are less test diffs now because we're not distinguishing loads from others instructions.
3. Updated test diffs.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13921 bytes
Desc: not available
More information about the llvm-commits