[PATCH] D29487: Make RWPI use movw/movt when available

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 03:39:49 PST 2017

olista01 added a comment.

The test change removes the tests of the constant-pool code path, but it looks like this path will still be used when optimising for size and not using execute-only. Could you extend the tests to check both code-paths?

Comment at: lib/Target/ARM/ARMISelLowering.cpp:3195
+      SDValue RelAddr = DAG.getNode(ARMISD::Wrapper, dl, PtrVT, G);
+      SDValue SB = DAG.getCopyFromReg(DAG.getEntryNode(), dl, ARM::R9, PtrVT);
+      SDValue Result = DAG.getNode(ISD::ADD, dl, PtrVT, SB, RelAddr);
The getCopyFromReg and ISD::ADD are duplicated, could they be pulled below the if?



More information about the llvm-commits mailing list