[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 16:31:00 PST 2017

phosek added inline comments.

Comment at: lib/crt/CMakeLists.txt:15
+  add_custom_target(${name} DEPENDS ${name}.o)
+  add_custom_target(install-${name}
+                    DEPENDS ${name}
beanz wrote:
> Unless I'm missing something it looks like you're missing the actual `install(...)` call. :-)
I've fixed that, as well as bunch of other issues that I revealed while testing this change, but this function started to resemble `add_compiler_rt_runtime` a lot, so I instead tried to modify `add_compiler_rt_runtime` to support `OBJECT`as an output type and it turned out to be pretty fairly straightforward. Let me know what you think about that approach.


More information about the llvm-commits mailing list