[PATCH] D29475: [LTO] Add ability to emit assembly to new LTO API

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 16:13:09 PST 2017


pcc added a comment.

I would echo Mehdi's comments: I think I would be surprised if `-save-temps` changed the output at all (it sounds like it would cause the linker to use a different assembler). If I were implementing this feature, I think I would consider alternatives first, such as making the "use an external assembler" feature orthogonal to `-save-temps`.

However, supporting a "use an external assembler" feature at the API level does not seem too burdensome. Can you please make a separate test in `LTO/Resolution` though?


https://reviews.llvm.org/D29475





More information about the llvm-commits mailing list