[llvm] r293345 - [InstCombine] move icmp transforms that might be recognized as min/max and inf-loop (PR31751)

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 14:31:51 PST 2017


r293947.

Thanks,
Hans

On Thu, Feb 2, 2017 at 2:13 PM, David Majnemer <david.majnemer at gmail.com> wrote:
> Let's merge this in.
>
> On Thu, Feb 2, 2017 at 1:58 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Mon, Jan 30, 2017 at 4:44 PM, Hans Wennborg <hans at chromium.org> wrote:
>> > On Fri, Jan 27, 2017 at 5:12 PM, Davide Italiano <davide at freebsd.org>
>> > wrote:
>> >> On Fri, Jan 27, 2017 at 5:11 PM, Davide Italiano <davide at freebsd.org>
>> >> wrote:
>> >>> On Fri, Jan 27, 2017 at 5:02 PM, Sanjay Patel <spatel at rotateright.com>
>> >>> wrote:
>> >>>> Understood - my POV is from trunk.
>> >>>>
>> >>>> If people think it's safer to revert patches for 4.0, I'd suggest
>> >>>> reverting
>> >>>> everything that was added to value tracking's matchMinMax() since
>> >>>> 3.9. That
>> >>>> should remove doubt (but miss quite a few min/max improvements).
>> >>>>
>> >>>
>> >>> I'm afraid that's not really feasible. At least this patch should be
>> >>> merged back to 4.0, FWIW.
>> >>>
>> >>
>> >> + Hans.
>> >
>> > David, what do you think as instcombine owner?
>>
>> Ping?
>
>


More information about the llvm-commits mailing list