[PATCH] D29168: [compiler-rt] Use interception to access to strong functions defined in the main executable.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 13:41:32 PST 2017

zturner added inline comments.

Comment at: lib/sanitizer_common/sanitizer_win_weak_interception.cc:34-35
+    (void *)GetModuleHandleA(0), real_function);
+  if (real && !__interception::OverrideFunction((uptr)dll_function, real, 0))
+    abort();
+  return 0;
I don't have a strong opinion here, but if the override fails, should it abort, or should it just behave as if the function was not found?


More information about the llvm-commits mailing list