[PATCH] D20116: Add speculatable function attribute
Tom Stellard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 12:19:34 PST 2017
tstellarAMD added a comment.
In https://reviews.llvm.org/D20116#664236, @mehdi_amini wrote:
> LGTM. But let's wait a little to give a change to @sanjoy or @chandlerc to comment if they feel the need.
> I repeat here one of the important earlier comment from @tstellarAMD , since it is not in the description and easy to miss:
> I added two new Intrinsic attributes IntrNoSideEffects and IntrHasSideEffects,
> which make it possible to specify all the possible memory interaction / side effect
> combinations. With these properties in place, it should be possible in the future
> to drop the 'no side effect' portion of the intrinsic memory properties once targets
> have been updated to use these new properties.
This comment is actually from an earlier version of the patch. I've dropped this part and wrote this patch instead: https://reviews.llvm.org/D22459
More information about the llvm-commits