[PATCH] D28961: [SLP] Fix for PR31690: Allow using of extra values in horizontal reductions.

[Michael Kuperstein via Phabricator via llvm-commits]

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

Argh, sorry, I didn't notice I didn't submit.
LGTM, but could you try to make the comment in line 4216 clearer? No need for another round of review.



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4152
+      // We ran into something like:
+      // ParentStackElem.first += ... + <ExtraArg_i> + ExtraArg + ...
+      // The whole ParentStackElem.first should be considered an extra value in
----------------
ABataev wrote:
> mkuper wrote:
> > Isn't "ParentStackElim.first" in this case just "<ExtraArg_i> + ExtraArg" itself? What you're trying to say is that ParentStackElem.first has two "extra" arguments, so it is itself an extra argument, right?
> Yes, I just provided some general description in C/C++ like format rather than in LLVM IR format.
Sure, what I meant is that I think this is a somewhat confusing description.


https://reviews.llvm.org/D28961