[PATCH] D29392: [ELF] - Change value checks to checkUInt for R_386_8/R_386_PC8/R_386_16/R_386_PC16 relocations.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:42:23 PST 2017


grimar added a comment.

In https://reviews.llvm.org/D29392#664879, @ruiu wrote:

> As I wrote, don't you need to use checkUInt for R_386_{8,16} and checkInt for R_386_PC{8,16}, do you?


As I also wrote, "Reproduce I have fails on R_386_PC16 relocation with value 0x000000000000fda3.", so checkInt already does not work for this relocation.

And I also metioned "I am observing R_386_PC8 relocation which is fails with new check because has value 358 == 0x166." so both types of checks will not work here in current code, no ?


https://reviews.llvm.org/D29392





More information about the llvm-commits mailing list