[PATCH] D29158: [compiler-rt] Add dynamic_runtime_thunk for different sanitizers.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:28:20 PST 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good to me. The only shared code changed is CMake, and I think the impact is low, so let's go ahead and land this.



================
Comment at: lib/sanitizer_common/CMakeLists.txt:204
+  set(DYNAMIC_RUNTIME_THUNK_CFLAGS "-DSANITIZER_DYNAMIC_RUNTIME_THUNK")
+  if(MSVC)
+    list(APPEND DYNAMIC_RUNTIME_THUNK_CFLAGS "-Zl")
----------------
This is in an `if (MSVC)` block. Let's simplify it.


https://reviews.llvm.org/D29158





More information about the llvm-commits mailing list