[PATCH] D29458: [asan] Move exception code to sanitizer_common.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:25:06 PST 2017


mpividori added a comment.

In https://reviews.llvm.org/D29458#665040, @kcc wrote:

> The amount if #if statements is extremely annoying, but we clearly don't want any more.
>
> I am not sure why you need this function declaration in lib/sanitizer_common/sanitizer_common.h
>  given that it's definition and its use is in *win* files.


Because we don't have a specific header for Windows interface in sanitizer_common. If you prefer, I can create: `sanitizer_windows.h` and add it there.


https://reviews.llvm.org/D29458





More information about the llvm-commits mailing list