[PATCH] D29373: NVPTX: Extract mem intrinsic expansions into utilities

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 11:13:01 PST 2017

jlebar added inline comments.

Comment at: include/llvm/Transforms/Utils/LowerMemIntrinsics.h:40
+                          unsigned SrcAlign, unsigned DestAlign,
+                          bool SrcIsVolatile, bool DstIsVolatile);
+void convertMemMoveToLoop(MemMoveInst *MemMove);
jlebar wrote:
> Do we really need these utilities for creating memmov and memset loops?  I guess they're kind of useful, but if nobody is using them our code isn't tested or anything, so maybe it's better to leave them out for now?
If you wanted, you could keep these functions as file-private in the cc file.  This way if we ever want to make them public, it's straightforward.


More information about the llvm-commits mailing list