[PATCH] D29458: [asan] Move exception code to sanitizer_common.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 10:43:47 PST 2017

rnk added inline comments.

Comment at: lib/sanitizer_common/sanitizer_common.h:384
 bool IsHandledDeadlySignal(int signum);
+bool IsHandledDeadlyException(DWORD exceptionCode);
kcc wrote:
> no #if please. 
> The only #if we accept (except for some special files) is a single #if around the entire file. 
sanitizer_common.h has a lot of #ifs, so I thought this was acceptable. If we just remove the if here, a caller will get a link error. Would you prefer that?


More information about the llvm-commits mailing list