[PATCH] D29441: [Assembler] Enable nicer diagnostics for inline assembly.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 09:34:07 PST 2017

rengolin added inline comments.

Comment at: include/llvm/CodeGen/AsmPrinter.h:114
+  /// A SourceMgr for inline assembly.
+  mutable std::unique_ptr<SourceMgr> InlineSrcMgr;
rnk wrote:
> rengolin wrote:
> > I'd move this line down, as it's being handled by the new methods there.
> Most classes seem to group fields together separately from methods, so I think this is fine.
Ok for me, then maybe bring `DiagInfos` up here and add a comment?


More information about the llvm-commits mailing list