[PATCH] D29011: [IR] Add Freeze instruction

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 09:19:54 PST 2017

filcab added a comment.

Looks good on my end. But please wait for someone more familiar with IR to chime in and LGTM, since I'm not sure of all places that need to be changed when adding instructions.

Comment at: include/llvm/IR/IRBuilder.h:1713
   /// \brief Return the i64 difference between two pointer values, dividing out
   /// the size of the pointed-to objects.
aqjune wrote:
> @filcab Other functions also have `\brief` , so I followed the convention.
Consistency is ok by me. If we ever convert these, we can do it on all at once.


More information about the llvm-commits mailing list