[PATCH] D29200: [JumpThread] Enhance finding partial redundant loads by continuing scanning single predecessor

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

Why is the right answer here to improve jump threading and not PRE if you want to catch more "partially redundant" loads ?

Additionally, why is this necessary at all?
-gvn already takes care of both of your testcases.



================
Comment at: llvm/trunk/lib/Analysis/Loads.cpp:316
+                                      AliasAnalysis *AA, bool *IsLoadCSE,
+                                      unsigned *NumScanedInst) {
   if (MaxInstsToScan == 0)
----------------
Scanned


================
Comment at: llvm/trunk/lib/Analysis/Loads.cpp:348
 
+    if (NumScanedInst)
+      ++(*NumScanedInst);
----------------
Scanned


================
Comment at: llvm/trunk/lib/Analysis/Loads.cpp:349
+    if (NumScanedInst)
+      ++(*NumScanedInst);
+
----------------
Scanned


Repository:
  rL LLVM

https://reviews.llvm.org/D29200