[lld] r293674 - Port r293519 and r293529.

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 2 04:16:12 PST 2017

On Thu, Feb 2, 2017 at 10:26 AM, Simon Atanasyan <simon at atanasyan.com> wrote:
> On Thu, Feb 2, 2017 at 12:41 AM, Peter Collingbourne <peter at pcc.me.uk> wrote:
>> It looks like the change that we are missing on the branch is r292161. If I
>> patch that change into the branch the basic-mips.s test passes but a number
>> of other tests fail. Probably the right thing to do at this point is to
>> update the test expectation, as the change does not appear to affect the
>> correctness of the output.
>> From the commit message, r292161 does itself look like a bug fix, so we may
>> want it on the branch anyway, but it isn't clear how important/feasible it
>> is. Simon, any thoughts?
> It looks like we need to backport r292161 because it fixes a
> significant problem.
> Trivial merge of this revision into the branch does not work due conflicts and
> some tests start to fail after merging. I will work on backporting the r292161.

I made backport of r292161 at r293879. Thanks to remember me about this fix.


Simon Atanasyan

More information about the llvm-commits mailing list