[PATCH] D29438: [XRay] Probe for CPU features that XRay needs

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 23:32:51 PST 2017

dberris added a comment.

In https://reviews.llvm.org/D29438#664410, @pelikan wrote:

> Nitpick (user-first): When false, the user will only see "Some CPU features are missing", not which ones.  I'd do another Report in the amd64 function specifically bragging about RDTSCP.  Most of these will be because of people running in too-restrictive VMs and will be resolved by "d'oh!" and fixing the support.

All good, that's a good idea anyway. I've made a change, PTAL?


More information about the llvm-commits mailing list