[PATCH] D29400: [ImplicitNullCheck] Extend Implicit Null Check scope by using stores

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 23:19:17 PST 2017

sanjoy added a comment.

If it is not too complicated, I'd rather have a single `FAULTING_OP` pseudo-instruction, and wrap loads, stores and load-stores into it.  We can then later re-use it for divisions as well (implicit division by zero checking).

Also, please update `docs/FaultMaps.rst`.

Comment at: lib/Target/X86/X86MCInstLower.cpp:976
+  if (StoreDefRegister != X86::NoRegister)
+    StoreMI.addOperand(MCOperand::createReg(StoreDefRegister));
When is `StoreDefRegister` not `X86::NoRegister`?


More information about the llvm-commits mailing list