[PATCH] D29438: [XRay] Probe for CPU features that XRay needs

Martin Pelikán via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 22:17:48 PST 2017


pelikan added a comment.

Nitpick (user-first): When false, the user will only see "Some CPU features are missing", not which ones.  I'd do another Report in the amd64 function specifically bragging about RDTSCP.  Most of these will be because of people running in too-restrictive VMs and will be resolved by "d'oh!" and fixing the support.


https://reviews.llvm.org/D29438





More information about the llvm-commits mailing list