[PATCH] D29435: Linker: Move special casing for available_externally in IRMover to clients. NFCI.
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 21:10:50 PST 2017
mehdi_amini added a comment.
Thanks for the tests! Still LGTM.
Comment at: llvm/lib/Linker/IRMover.cpp:875
- return true;
if (SGV.isDeclaration() || DoneLinkingBodies)
> mehdi_amini wrote:
> > No test changed, that's annoying that we're not covering this case (independently of the new LTO API). Any idea how to test this? (along with the removal below as well)
> The only direct users of IRMover are LinkModules and LTO. I guess we could write a unit test for IRMover perhaps? Doesn't seem worth it for this one change though.
I wouldn't suggest it :)
More information about the llvm-commits