[PATCH] D29435: Linker: Move special casing for available_externally in IRMover to clients. NFCI.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 18:56:07 PST 2017

tejohnson added inline comments.

Comment at: llvm/lib/Linker/LinkModules.cpp:398
-             (GV.hasLocalLinkage() || GV.hasLinkOnceLinkage() ||
-              GV.hasAvailableExternallyLinkage()))
     return false;
I guess removing this is required to make it NFC. Is it required for correctness too? I don't think so but want to make sure my understanding is right. Is it better to continue not mapping these in here (I think they get mapped later if referenced, right?) and not bother making this NFC?


More information about the llvm-commits mailing list