[PATCH] D29435: Linker: Move special casing for available_externally in IRMover to clients. NFCI.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:481
+          Keep.push_back(GV);
       }
     }
----------------
Do we have a test that shows that:

1) if we first import an available_externally, then a later linkonce_odr (and/or strong) would overwrite?
2) if we first import a linkonce_odr (and/or strong), a later available_externally wouldn't overwrite?


================
Comment at: llvm/lib/Linker/IRMover.cpp:875
-    return true;
-
   if (SGV.isDeclaration() || DoneLinkingBodies)
----------------
No test changed, that's annoying that we're not covering this case (independently of the new LTO API). Any idea how to test this? (along with the removal below as well)


https://reviews.llvm.org/D29435