[PATCH] D29407: AsmPrinter: Emit debug information sections lasst
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 16:58:53 PST 2017
Matthias Braun via Phabricator <reviews at reviews.llvm.org> writes:
> MatzeB created this revision.
> Herald added subscribers: mehdi_amini, mcrosier.
> Attaching debug information should ideally not change the rest of the
> binary. This works best when the debug information sections come last in
> the file. See also the discussion in https://reviews.llvm.org/D29315 or
> r197922 or rdar://15623193
> This means that we should output the debug information after calling the
> targets EmitEndOfAsmFile.
> @Rafael: Could you please look at the changes to test/DebugInfo/X86/arange-and-stub.ll. This patch moves ".section .data.DW.ref.foo,"aGw", at progbits,DW.ref.foo,comdat" from the end of the file to before the debug info which "CHECK: .data" catches unitentionally I think.
Change to arange-and-stub.ll is fine.
More information about the llvm-commits