[PATCH] D29404: [ValueTracking] emit a warning when we detect a conflicting assumption (PR31809)
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 16:03:39 PST 2017
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
I think this patch has still some problems (but please correct me if I'm wrong).
Here you're adding a dependency on `OptimizationRemarkEmitter` but, isn't that supposed to be used as an analysis?
If so, your pass should probably request it (and you should stick the `ORE` somewhere).
More information about the llvm-commits